urlmon: Fixed IUriBuilderFactory declaration.
authorJacek Caban <jacek@codeweavers.com>
Mon, 3 Jan 2011 22:48:18 +0000 (23:48 +0100)
committerAlexandre Julliard <julliard@winehq.org>
Tue, 4 Jan 2011 10:11:49 +0000 (11:11 +0100)
dlls/urlmon/tests/uri.c
dlls/urlmon/uri.c
include/urlmon.idl

index fd9099ce83e54fe608dfc821c950cdefbe1b380b..44f438f35804245177b8aa119ba3023d6feaa6af 100644 (file)
@@ -9090,23 +9090,23 @@ static void test_IUriBuilderFactory(void) {
 
         if(SUCCEEDED(hr)) {
             builder = (void*) 0xdeadbeef;
-            hr = IUriBuilderFactory_CreateInitializedIUriBuilder(factory, 10, 0, &builder);
+            hr = IUriBuilderFactory_CreateIUriBuilder(factory, 10, 0, &builder);
             ok(hr == E_INVALIDARG, "Error: CreateInitializedIUriBuilder returned 0x%08x, expected 0x%08x.\n",
                 hr, E_INVALIDARG);
             ok(!builder, "Error: Expected 'builder' to be NULL, but was %p.\n", builder);
 
             builder = (void*) 0xdeadbeef;
-            hr = IUriBuilderFactory_CreateInitializedIUriBuilder(factory, 0, 10, &builder);
+            hr = IUriBuilderFactory_CreateIUriBuilder(factory, 0, 10, &builder);
             ok(hr == E_INVALIDARG, "Error: CreateInitializedIUriBuilder returned 0x%08x, expected 0x%08x.\n",
                 hr, E_INVALIDARG);
             ok(!builder, "Error: Expected 'builder' to be NULL, but was %p.\n", builder);
 
-            hr = IUriBuilderFactory_CreateInitializedIUriBuilder(factory, 0, 0, NULL);
+            hr = IUriBuilderFactory_CreateIUriBuilder(factory, 0, 0, NULL);
             ok(hr == E_POINTER, "Error: CreateInitializedIUriBuilder returned 0x%08x, expected 0x%08x.\n",
                 hr, E_POINTER);
 
             builder = NULL;
-            hr = IUriBuilderFactory_CreateInitializedIUriBuilder(factory, 0, 0, &builder);
+            hr = IUriBuilderFactory_CreateIUriBuilder(factory, 0, 0, &builder);
             ok(hr == S_OK, "Error: CreateInitializedIUriBuilder returned 0x%08x, expected 0x%08x.\n",
                 hr, S_OK);
             if(SUCCEEDED(hr)) {
@@ -9114,9 +9114,6 @@ static void test_IUriBuilderFactory(void) {
                 LPCWSTR result;
                 DWORD result_len;
 
-                /* Seems microsoft had a bit of mixup naming this function. It
-                 * returns an uninitialized IUriBuilder.
-                 */
                 hr = IUriBuilder_GetIUri(builder, &tmp);
                 ok(hr == S_OK, "Error: GetIUri returned 0x%08x, expected 0x%08x.\n",
                     hr, S_OK);
@@ -9129,23 +9126,23 @@ static void test_IUriBuilderFactory(void) {
             if(builder) IUriBuilder_Release(builder);
 
             builder = (void*) 0xdeadbeef;
-            hr = IUriBuilderFactory_CreateIUriBuilder(factory, 10, 0, &builder);
+            hr = IUriBuilderFactory_CreateInitializedIUriBuilder(factory, 10, 0, &builder);
             ok(hr == E_INVALIDARG, "Error: CreateIUriBuilder returned 0x%08x, expected 0x%08x.\n",
                 hr, E_INVALIDARG);
             ok(!builder, "Error: Expected 'builder' to be NULL, but was %p.\n", builder);
 
             builder = (void*) 0xdeadbeef;
-            hr = IUriBuilderFactory_CreateIUriBuilder(factory, 0, 10, &builder);
+            hr = IUriBuilderFactory_CreateInitializedIUriBuilder(factory, 0, 10, &builder);
             ok(hr == E_INVALIDARG, "Error: CreateIUriBuilder returned 0x%08x, expected 0x%08x.\n",
                 hr, E_INVALIDARG);
             ok(!builder, "Error: Expected 'builder' to be NULL, but was %p.\n", builder);
 
-            hr = IUriBuilderFactory_CreateIUriBuilder(factory, 0, 0, NULL);
+            hr = IUriBuilderFactory_CreateInitializedIUriBuilder(factory, 0, 0, NULL);
             ok(hr == E_POINTER, "Error: CreateIUriBuilder returned 0x%08x, expected 0x%08x.\n",
                 hr, E_POINTER);
 
             builder = NULL;
-            hr = IUriBuilderFactory_CreateIUriBuilder(factory, 0, 0, &builder);
+            hr = IUriBuilderFactory_CreateInitializedIUriBuilder(factory, 0, 0, &builder);
             ok(hr == S_OK, "Error: CreateIUriBuilder returned 0x%08x, expected 0x%08x.\n",
                 hr, S_OK);
             if(SUCCEEDED(hr)) {
index 825c6c502008e1fc57704c47ec1d951b7172b07c..7f8a441c211e30b2c10edde1222f7f4004d21de1 100644 (file)
@@ -5007,10 +5007,10 @@ static ULONG WINAPI UriBuilderFactory_Release(IUriBuilderFactory *iface)
     return ref;
 }
 
-static HRESULT WINAPI UriBuilderFactory_CreateInitializedIUriBuilder(IUriBuilderFactory *iface,
-                                                              DWORD dwFlags,
-                                                              DWORD_PTR dwReserved,
-                                                              IUriBuilder **ppIUriBuilder)
+static HRESULT WINAPI UriBuilderFactory_CreateIUriBuilder(IUriBuilderFactory *iface,
+                                                          DWORD dwFlags,
+                                                          DWORD_PTR dwReserved,
+                                                          IUriBuilder **ppIUriBuilder)
 {
     Uri *This = impl_from_IUriBuilderFactory(iface);
     TRACE("(%p)->(%08x %08x %p)\n", This, dwFlags, (DWORD)dwReserved, ppIUriBuilder);
@@ -5026,10 +5026,10 @@ static HRESULT WINAPI UriBuilderFactory_CreateInitializedIUriBuilder(IUriBuilder
     return CreateIUriBuilder(NULL, 0, 0, ppIUriBuilder);
 }
 
-static HRESULT WINAPI UriBuilderFactory_CreateIUriBuilder(IUriBuilderFactory *iface,
-                                                   DWORD dwFlags,
-                                                   DWORD_PTR dwReserved,
-                                                   IUriBuilder **ppIUriBuilder)
+static HRESULT WINAPI UriBuilderFactory_CreateInitializedIUriBuilder(IUriBuilderFactory *iface,
+                                                                     DWORD dwFlags,
+                                                                     DWORD_PTR dwReserved,
+                                                                     IUriBuilder **ppIUriBuilder)
 {
     Uri *This = impl_from_IUriBuilderFactory(iface);
     TRACE("(%p)->(%08x %08x %p)\n", This, dwFlags, (DWORD)dwReserved, ppIUriBuilder);
@@ -5049,8 +5049,8 @@ static const IUriBuilderFactoryVtbl UriBuilderFactoryVtbl = {
     UriBuilderFactory_QueryInterface,
     UriBuilderFactory_AddRef,
     UriBuilderFactory_Release,
-    UriBuilderFactory_CreateInitializedIUriBuilder,
-    UriBuilderFactory_CreateIUriBuilder
+    UriBuilderFactory_CreateIUriBuilder,
+    UriBuilderFactory_CreateInitializedIUriBuilder
 };
 
 static Uri* create_uri_obj(void) {
index d2a46a08cc2df1582040dc020fd7ecf35313e998..240b6a738eefa62f0359fcf7984cc7478ad6fe08 100644 (file)
@@ -1839,16 +1839,16 @@ cpp_quote("HRESULT WINAPI CreateIUriBuilder(IUri*,DWORD,DWORD_PTR,IUriBuilder**)
 ]
 interface IUriBuilderFactory : IUnknown
 {
-    HRESULT CreateInitializedIUriBuilder(
+    HRESULT CreateIUriBuilder(
         [in]  DWORD dwFlags,
         [in]  DWORD_PTR dwReserved,
         [out] IUriBuilder **ppIUriBuilder);
 
-    HRESULT CreateIUriBuilder(
+    HRESULT CreateInitializedIUriBuilder(
         [in]  DWORD dwFlags,
         [in]  DWORD_PTR dwReserved,
         [out] IUriBuilder **ppIUriBuilder);
-};
+}
 
 /*****************************************************************************
  * IInternetProtocolEx interface