oleaut32: Added MEMBERID_NIL handling to ICreateTypeInfo_LayOut.
authorPiotr Caban <piotr@codeweavers.com>
Mon, 22 Feb 2010 00:58:39 +0000 (01:58 +0100)
committerAlexandre Julliard <julliard@winehq.org>
Mon, 22 Feb 2010 11:02:22 +0000 (12:02 +0100)
dlls/oleaut32/tests/typelib.c
dlls/oleaut32/typelib2.c

index 2a04ae94ed6cf0c9556e9926222122808632db3f..e75d320edd1fb8b4867ab359a27331b057ec8856 100644 (file)
@@ -1041,6 +1041,10 @@ static void test_CreateTypeLib(void) {
     hres = ICreateTypeInfo_AddFuncDesc(createti, 1, &funcdesc);
     ok(hres == S_OK, "got %08x\n", hres);
 
+    funcdesc.memid = MEMBERID_NIL;
+    hres = ICreateTypeInfo_AddFuncDesc(createti, 1, &funcdesc);
+    ok(hres == S_OK, "got %08x\n", hres);
+
     ICreateTypeInfo_Release(createti);
 
     hres = ICreateTypeLib_CreateTypeInfo(createtl, interface1W, TKIND_INTERFACE, &createti);
index 6eb13af9240e43dfd11887cf37553c8a7b07c21a..e1a36b23fad435045abaaf23217cc0dd31baa401 100644 (file)
@@ -1994,8 +1994,25 @@ static HRESULT WINAPI ICreateTypeInfo2_fnLayOut(
     i = 0;
     This->typeinfo->cbSizeVft = 0;
     for(iter=This->typedata->next->next; iter!=This->typedata->next; iter=iter->next) {
-        if(iter->indice == MEMBERID_NIL)
-            FIXME("MEMBERID_NIL handling not yet implemented\n");
+        /* Assign MEMBERID if MEMBERID_NIL was specified */
+        if(iter->indice == MEMBERID_NIL) {
+            iter->indice = 0x60000000 + i;
+
+            for(iter2=This->typedata->next->next; iter2!=This->typedata->next; iter2=iter2->next) {
+                if(iter == iter2) continue;
+                if(iter2->indice == iter->indice) {
+                    iter->indice = 0x5fffffff + This->typeinfo->cElement + i;
+
+                    for(iter2=This->typedata->next->next; iter2!=This->typedata->next; iter2=iter2->next) {
+                        if(iter == iter2) continue;
+                        if(iter2->indice == iter->indice)
+                            return E_ACCESSDENIED;
+                    }
+
+                    break;
+                }
+            }
+        }
 
         typedata[i] = iter;