Better handling of errors in RenderFile.
authorChristian Costa <titan.costa@wanadoo.fr>
Mon, 6 Dec 2004 11:47:13 +0000 (11:47 +0000)
committerAlexandre Julliard <julliard@winehq.org>
Mon, 6 Dec 2004 11:47:13 +0000 (11:47 +0000)
dlls/quartz/filtergraph.c

index b10756319e687c64060250eb2aad0d42f3d8ac21..1f5664686c418268dc37de118606ab750ae72604 100644 (file)
@@ -949,7 +949,8 @@ static HRESULT WINAPI Graphbuilder_RenderFile(IGraphBuilder *iface,
     }
 
     /* Render all output pin of the splitter by calling IGraphBuilder_Render on each of them */
-    hr = GetInternalConnections(psplitter, ppinsplitter, &ppins, &nb);
+    if (SUCCEEDED(hr))
+        hr = GetInternalConnections(psplitter, ppinsplitter, &ppins, &nb);
     
     if (SUCCEEDED(hr)) {
         int i;
@@ -963,10 +964,10 @@ static HRESULT WINAPI Graphbuilder_RenderFile(IGraphBuilder *iface,
                 break;
             }
         }
+        CoTaskMemFree(ppins);
     }
-    CoTaskMemFree(ppins);
     
-    return S_OK;
+    return hr;
 }
 
 static HRESULT WINAPI Graphbuilder_AddSourceFilter(IGraphBuilder *iface,