msi: Get rid of some redundant initializations.
authorHans Leidekker <hans@codeweavers.com>
Mon, 19 Oct 2009 09:14:20 +0000 (11:14 +0200)
committerAlexandre Julliard <julliard@winehq.org>
Mon, 19 Oct 2009 13:02:42 +0000 (15:02 +0200)
dlls/msi/database.c
dlls/msi/msiquery.c
dlls/msi/package.c
dlls/msi/preview.c
dlls/msi/suminfo.c

index 4db7c01041e07aea3607c02e5a02e5476ae3672f..8d0ee42ea025794ebc85fffb9a548a02ff22a86c 100644 (file)
@@ -191,8 +191,6 @@ UINT MSI_OpenDatabaseW(LPCWSTR szDBPath, LPCWSTR szPersist, MSIDATABASE **pdb)
     db->mode = szMode;
     if (created)
         db->deletefile = strdupW( szDBPath );
-    else
-        db->deletefile = NULL;
     list_init( &db->tables );
     list_init( &db->transforms );
 
index 5a46f9b5cb66aa573b847a6be4b887a8bbb495ce..b9733820a69045e2cccb468a7c5ef61150f4cdad 100644 (file)
@@ -126,9 +126,7 @@ UINT MSI_DatabaseOpenViewW(MSIDATABASE *db,
         return ERROR_FUNCTION_FAILED;
 
     msiobj_addref( &db->hdr );
-    query->row = 0;
     query->db = db;
-    query->view = NULL;
     list_init( &query->mem );
 
     r = MSI_ParseSQL( db, szQuery, &query->view, &query->mem );
index 9c9284244a99001e39cf443a5b49c123064de0aa..fa0cd6f2b3bb59b7d42c945f9efe9553ea3f1dcb 100644 (file)
@@ -744,15 +744,6 @@ static MSIPACKAGE *msi_alloc_package( void )
         list_init( &package->RunningActions );
         list_init( &package->sourcelist_info );
         list_init( &package->sourcelist_media );
-
-        package->patch = NULL;
-        package->ActionFormat = NULL;
-        package->LastAction = NULL;
-        package->dialog = NULL;
-        package->next_dialog = NULL;
-        package->scheduled_action_running = FALSE;
-        package->commit_action_running = FALSE;
-        package->rollback_action_running = FALSE;
     }
 
     return package;
index a2b3f3222859f3939eac1011ab17d0fff5bf4fa3..458e4a1cb0bb97d6324819b05829512c986bf7f9 100644 (file)
@@ -54,7 +54,6 @@ static MSIPREVIEW *MSI_EnableUIPreview( MSIDATABASE *db )
         if( preview )
         {
             preview->package = package;
-            preview->dialog = 0;
             msiobj_addref( &package->hdr );
         }
         msiobj_release( &package->hdr );
index ef16665b781df5dedf8ab0e15f9fadd3bf6ae4c4..d3db44aa36e71d8199e933b90e8f3506b5f5b21f 100644 (file)
@@ -443,7 +443,6 @@ MSISUMMARYINFO *MSI_GetSummaryInformationW( IStorage *stg, UINT uiUpdateCount )
     if( !si )
         return si;
 
-    memset( si->property, 0, sizeof si->property );
     si->update_count = uiUpdateCount;
     IStorage_AddRef( stg );
     si->storage = stg;